Add documentation about the manifest.yaml #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason/Description: So it is clear how to change properties of the packages Files: README.md
Reason/Description: Otherwise gradle complains Files: README.md, mod.rs, and settings.gradle
Reason: to make clear that Cargo.toml is required at the end
Murmele
commented
Nov 10, 2025
Murmele
commented
Nov 10, 2025
Murmele
commented
Nov 12, 2025
| let _ = std::fs::remove_dir_all(&base_assets); | ||
|
|
||
| if !config.assets.is_empty() { | ||
| std::fs::OpenOptions::new().write(true).append(true).open(gradle.join("settings.gradle"))?.write(r#"include ':baseAssets'"#.as_bytes())?; |
Author
There was a problem hiding this comment.
@MarijnS95 I have to delete the baseAssets include from settings.grade and adding it if assets are present, otherwise I get a gradle error
Could not open cp_settings generic class cache for settings file '/target/x/release/android/gradle/settings.gradle' (~/.gradle/caches/8.1.1/scripts/d5f98u8ma4q13uozubkfsaw6z).
BUG! exception in phase 'semantic analysis' in source unit 'BuildScript' Unsupported class file major version 65
|
This PR would have saved me an hour of studying the code. Where can I sign a petition to promote PR?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it is clear how to change properties of the packages